chore: deny unused results #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1825 +/- ##
===========================================
- Coverage 86.51% 86.22% -0.30%
===========================================
Files 587 587
Lines 95642 95607 -35
===========================================
- Hits 82745 82434 -311
- Misses 12897 13173 +276 |
evenyag
reviewed
Jun 26, 2023
There was a problem hiding this comment.
This lint is too verbose. Could we add #[must_use] to methods that need this check instead?
https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute
I still prefer using unwrap() as it yields the error message. Assertion on |
MichaelScofield
force-pushed
the
chore/deny-unused-results
branch
from
e2fb357
to
db6edab
Compare
WenyXu
approved these changes
Jun 26, 2023
MichaelScofield
force-pushed
the
chore/deny-unused-results
branch
from
db6edab
to
4e9a76f
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: deny unused results * rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The rustc lint: "deny unused-results" can check whether a return value is handled or not.
Pros to this lint: force people to deal with all return values, reduce the possibility of lurked bugs. Cons: sometimes could be annoying, even the most trivial return values (
HashMap::insertfor example) have to be dealt with.According to our internal poll to date (positive 4, neutral 4, negative 0), we decide to enable it.
This PR goes through all our codes and fix all the warnings. Mainly:
let _ = ...HashMap::fromwhere possibleassert!(result.is_ok())instead ofresult.unwrap()Checklist
Refer to a related PR or issue link (optional)